On 2022/8/10 1:18, Matthew Wilcox (Oracle) wrote:
> Save 17 bytes of text by calculating page_zone() once instead of twice.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Thanks.
> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index e5486d47406e..2745865a57c5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3483,16 +3483,16 @@ void free_unref_page(struct page *page, unsigned int order)
> * areas back if necessary. Otherwise, we may have to free
> * excessively into the page allocator
> */
> + zone = page_zone(page);
> migratetype = get_pcppage_migratetype(page);
> if (unlikely(migratetype >= MIGRATE_PCPTYPES)) {
> if (unlikely(is_migrate_isolate(migratetype))) {
> - free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE);
> + free_one_page(zone, page, pfn, order, migratetype, FPI_NONE);
> return;
> }
> migratetype = MIGRATE_MOVABLE;
> }
>
> - zone = page_zone(page);
> pcp_trylock_prepare(UP_flags);
> pcp = pcp_spin_trylock_irqsave(zone->per_cpu_pageset, flags);
> if (pcp) {
>
