Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/mm-vmscan-define-macros-for-refaults-in-struct-lruvec/20220802-151054 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220807/202208071759.nIRUnjYn-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/cb852a4d1456d03ec22ce56b90e321d14c853bb7 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review cgel-zte-gmail-com/mm-vmscan-define-macros-for-refaults-in-struct-lruvec/20220802-151054 git checkout cb852a4d1456d03ec22ce56b90e321d14c853bb7 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/build_bug.h:5, from include/linux/container_of.h:5, from include/linux/list.h:5, from include/linux/swait.h:5, from include/linux/completion.h:12, from fs/nfs/delegation.c:10: fs/nfs/delegation.c: In function 'nfs_inode_set_delegation': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/delegation.c:476:17: note: in expansion of macro 'dfprintk' 476 | dfprintk(FILE, "%s: server %s handed out " | ^~~~~~~~ include/linux/nfs_fs.h:623:58: note: each undeclared identifier is reported only once for each function it appears in 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/delegation.c:476:17: note: in expansion of macro 'dfprintk' 476 | dfprintk(FILE, "%s: server %s handed out " | ^~~~~~~~ -- In file included from include/linux/export.h:33, from include/linux/linkage.h:7, from arch/x86/include/asm/cache.h:5, from include/linux/cache.h:6, from include/linux/time.h:5, from include/linux/compat.h:10, from fs/nfs/dir.c:21: fs/nfs/dir.c: In function 'nfs_opendir': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/dir.c:116:9: note: in expansion of macro 'dfprintk' 116 | dfprintk(FILE, "NFS: open dir(%pD2)\n", filp); | ^~~~~~~~ include/linux/nfs_fs.h:623:58: note: each undeclared identifier is reported only once for each function it appears in 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/dir.c:116:9: note: in expansion of macro 'dfprintk' 116 | dfprintk(FILE, "NFS: open dir(%pD2)\n", filp); | ^~~~~~~~ fs/nfs/dir.c: In function 'nfs_readdir': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/dir.c:1220:9: note: in expansion of macro 'dfprintk' 1220 | dfprintk(FILE, "NFS: readdir(%pD2) starting at cookie %llu\n", | ^~~~~~~~ fs/nfs/dir.c: In function 'nfs_llseek_dir': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/dir.c:1316:9: note: in expansion of macro 'dfprintk' 1316 | dfprintk(FILE, "NFS: llseek dir(%pD2, %lld, %d)\n", | ^~~~~~~~ fs/nfs/dir.c: In function 'nfs_fsync_dir': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/dir.c:1360:9: note: in expansion of macro 'dfprintk' 1360 | dfprintk(FILE, "NFS: fsync dir(%pD2) datasync %d\n", filp, datasync); | ^~~~~~~~ -- In file included from arch/x86/include/asm/current.h:5, from include/linux/sched.h:12, from fs/nfs/direct.c:43: fs/nfs/direct.c: In function 'nfs_file_direct_read': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/direct.c:453:9: note: in expansion of macro 'dfprintk' 453 | dfprintk(FILE, "NFS: direct read(%pD2, %zd@%Ld)\n", | ^~~~~~~~ include/linux/nfs_fs.h:623:58: note: each undeclared identifier is reported only once for each function it appears in 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/direct.c:453:9: note: in expansion of macro 'dfprintk' 453 | dfprintk(FILE, "NFS: direct read(%pD2, %zd@%Ld)\n", | ^~~~~~~~ fs/nfs/direct.c: In function 'nfs_file_direct_write': >> include/linux/nfs_fs.h:623:58: error: 'NFSDBG_1' undeclared (first use in this function); did you mean 'NFSDBG_ALL'? 623 | # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) | ^~~~~~~ include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/sunrpc/debug.h:39:9: note: in expansion of macro 'ifdebug' 39 | ifdebug(fac) \ | ^~~~~~~ fs/nfs/direct.c:909:9: note: in expansion of macro 'dfprintk' 909 | dfprintk(FILE, "NFS: direct write(%pD2, %zd@%Ld)\n", | ^~~~~~~~ vim +623 include/linux/nfs_fs.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 619 4dc2eaecd4cf06 Benny Halevy 2006-12-20 620 ^1da177e4c3f41 Linus Torvalds 2005-04-16 621 # undef ifdebug ^1da177e4c3f41 Linus Torvalds 2005-04-16 622 # ifdef NFS_DEBUG ^1da177e4c3f41 Linus Torvalds 2005-04-16 @623 # define ifdebug(fac) if (unlikely(nfs_debug & NFSDBG_##fac)) -- 0-DAY CI Kernel Test Service https://01.org/lkp
