On 8/5/22 13:14, Doug Anderson wrote:
Hi,
On Fri, Jul 22, 2022 at 5:17 PM Hillf Danton <hdanton@xxxxxxxx> wrote:
On Fri, 22 Jul 2022 07:02:42 -0700 Doug Anderson wrote:
Thanks! I added this diff to your previous diff and my simple test
still passes and I don't see your WARN_ON triggered.
Thanks!
How do we move forward? Are you going to officially submit a patch
with both of your diffs squashed together? Are we waiting for
additional review from someone?
Given it is not unusual for us to miss anything important, lets take
a RWSEM_WAIT_TIMEOUT nap now or two.
It appears that another fix has landed in the meantime. Commit
6eebd5fb2083 ("locking/rwsem: Allow slowpath writer to ignore handoff
bit if not set by first waiter").
...unfortunately with that patch my test cases still hangs. :(
The aim of commit 6eebd5fb2083 ("locking/rwsem: Allow slowpath writer to
ignore handoff bit if not set by first waiter") is to restore slowpath
writer behavior to be the same as before commit d257cc8cb8d5
("locking/rwsem: Make handoff bit handling more consistent").
If the hang still exists, there may be other cause for it. Could you
share more information about what the test case is doing and any kernel
splat that you have?
Thanks,
Longman
