On Aug 4, 2022, at 10:07 AM, Peter Xu <peterx@xxxxxxxxxx> wrote: > On Wed, Aug 03, 2022 at 11:42:39PM -0700, Nadav Amit wrote: >> On Aug 3, 2022, at 9:45 AM, Peter Xu <peterx@xxxxxxxxxx> wrote: > > For this series, I can think more of dropping the young bit for migration > entry during these madvises (which should be relatively safe with the > pgtable held, since I don't need to touch the page but just modify the swap > entry within), but probably that's not really the major problem here, so > not sure whether that matters a huge lot (e.g., for FREE we should really > drop the whole entry?). Sounds good to me. I just had a look whether the swap entry should be checked and hit these additional cases, so I thought they are worthy of consideration. But as they are already not handling some cases, which is valid for madvise's hints, leaving it to later sounds fine. Handling migration entries anyhow might not be worthy of the risk of breaking something.
