On 2022/8/4 8:45, HORIGUCHI NAOYA(堀口 直也) wrote:
On Tue, Aug 02, 2022 at 10:12:56AM +0800, Kefeng Wang wrote:Since commit 5d1fd5dc877b ("mm,hwpoison: introduce MF_MSG_UNSPLIT_THP"), the action_result() called to show memory error event in memory_failure(), so the pr_info() in try_to_split_thp_page() is only needed in soft_offline_in_use_page(). Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>Thanks, looks good to me. Probably this patch may come before "mm: memory-failure: convert to pr_fmt()" to be a cleanup. And recently another patch [1] is trying to change the same function, so we might need to resolve the conflict with it. I expect it's not so hard, but I think your series had better come after [1] because [1] is a bug fix and might be backported to stable-5.19.
OK， I could repost after[1] merged into mm tree, thanks.
[1] https://lore.kernel.org/linux-mm/20220803025243.155798-1-fengwei.yin@xxxxxxxxx/T/#u Thanks, Naoya Horiguchi
