On Wed, 3 Aug 2022 08:24:08 +0800 kernel test robot <lkp@xxxxxxxxx> wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-stable > head: 1a44131d4f524e18d873bbe363598e39841001bf > commit: f6c3e1ae0114cd0f5123cf38187d450c1b119e67 [242/251] mm/hmm: add a test for cross device private faults > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce: > # https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=f6c3e1ae0114cd0f5123cf38187d450c1b119e67 > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > git fetch --no-tags akpm-mm mm-stable > git checkout f6c3e1ae0114cd0f5123cf38187d450c1b119e67 > make O=/tmp/kselftest headers > make O=/tmp/kselftest -C tools/testing/selftests > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > hmm-tests.c: In function 'hmm2_double_map': > >> hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared (first use in this function); did you mean 'HMM_DMIRROR_WRITE'? > 1607 | ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages); > | ^~~~~~~~~~~~~~~~~~~ > | HMM_DMIRROR_WRITE > hmm-tests.c:1607:42: note: each undeclared identifier is reported only once for each function it appears in oops, thanks. It's been a week - I'm surprised this wasn't picked up sooner? Ralph, Alistair, is this right? From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: tools/testing/selftests/vm/hmm-tests.c: fix build Date: Tue Aug 2 06:03:03 PM PDT 2022 hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared (first use in this function); did you mean 'HMM_DMIRROR_WRITE'? Fixes: f6c3e1ae0114cd0 ("mm/hmm: add a test for cross device private faults") Reported-by: kernel test robot <lkp@xxxxxxxxx> Cc: Ralph Campbell <rcampbell@xxxxxxxxxx> Cc: Alistair Popple <apopple@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- tools/testing/selftests/vm/hmm-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/vm/hmm-tests.c~tools-testing-selftests-vm-hmm-testsc-fix-build +++ a/tools/testing/selftests/vm/hmm-tests.c @@ -1604,7 +1604,7 @@ TEST_F(hmm2, double_map) ASSERT_EQ(ptr[i], i); /* Migrate pages to device 1 and try to read from device 0. */ - ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages); + ret = hmm_migrate_sys_to_dev(self->fd1, buffer, npages); ASSERT_EQ(ret, 0); ASSERT_EQ(buffer->cpages, npages); _
