On Wed, Jul 27, 2022 at 06:07:33PM +0800, Liu Xinpeng wrote:
> Do 'make -C tools/testing/memblock', get the following errors:
>
> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>
> Fixes: 902c2d91582c ("memblock: Disable mirror feature if kernelcore is not specified")
> Fixes: 14d9a675fd0d ("mm: Ratelimited mirrored memory related warning messages")
>
> Signed-off-by: Liu Xinpeng <liuxp11@xxxxxxxxxxxxxxx>
> Tested-by: Ma Wupeng <mawupeng1@xxxxxxxxxx>
Applied, thanks!
> ---
> Changelog:
> V3 -> V4: Changed the title and add how to reproduce this issue.
> V2 -> V3: Fixs should not have word wrap.
> V1 -> V2: Removed comma in macro define and addressed review comments.
> ---
> tools/testing/memblock/internal.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c05e0c..fdb7f5db7308 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,10 @@
> static int memblock_debug = 1;
> #endif
>
> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__)
> +
> +bool mirrored_kernelcore = false;
> +
> struct page {};
>
> void memblock_free_pages(struct page *page, unsigned long pfn,
> --
> 1.8.3.1
>
--
Sincerely yours,
Mike.
