Konstantin Khlebnikov wrote:
@@ -2480,8 +2494,11 @@ static int mem_cgroup_move_parent(struct page *page,
if (nr_pages> 1)
compound_unlock_irqrestore(page, flags);
+ if (!ret)
+ /* This also stabilize PageLRU() sign for lruvec lock holder. */
+ mem_cgroup_adjust_isolated(lruvec, page, -nr_pages);
put_back:
- putback_lru_page(page);
+ __putback_lru_page(page, !ret);
put:
put_page(page);
out:
Oh, no. There must be !!ret
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2482,7 +2482,7 @@ static int mem_cgroup_move_parent(struct page *page,
/* This also stabilize PageLRU() sign for lruvec lock holder. */
mem_cgroup_adjust_isolated(lruvec, page, -nr_pages);
put_back:
- __putback_lru_page(page, !ret);
+ __putback_lru_page(page, !!ret);
put:
put_page(page);
out:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>