On Mon, Jul 18, 2022 at 12:28:34PM -0700, Yury Norov wrote: > One of bitmap_cut() tests passed it with: > nbits = BITS_PER_LONG; > first = BITS_PER_LONG; > cut = BITS_PER_LONG; > > This test is useless because the range to cut is not inside the > bitmap. This should normally raise an error, but bitmap_cut() is > void and returns nothing. > > To check if the test is passed, it just tests that the memory is > not touched by bitmap_cut(), which is probably not correct, because > if a function is passed with wrong parameters, it's too optimistic > to expect a correct, or even sane behavior. > > Now that we have bitmap_check_params(), there's a tool to detect such > things in real code, and we can drop the test. There are no "useless" tests. Same comments as per a couple of previous patches. -- With Best Regards, Andy Shevchenko
