On Sun, Jul 17, 2022 at 03:47:55PM +0100, Matthew Wilcox wrote: > If this is the only change needed, then clearly they're not being used, > so just delete them? There is no definition of the struct maple_enode or maple_pnode. This struct is only used as a pointer. There are some comments about this pointer, which will be gone if we delete these two typedef statements. If you worry about generating a not used data type, it may be better to change `struct maple_enode *foo` to `maple_enode_p foo`. This keeps the code more readable and used the maple_enode_p type.