On Fri, Jul 15, 2022 at 10:29:33AM -0700, Mike Kravetz wrote: > On 07/15/22 13:07, Peter Xu wrote: > > On Fri, Jul 15, 2022 at 09:45:37AM -0700, Axel Rasmussen wrote: > > > I don't really have a strong preference between the two. The second option > > > is what I originally proposed in the first version of the minor fault > > > series, so going back to that isn't a problem at least from my perspective. > > > If in the future we find a real use case for this, we could always easily > > > re-enable it and add selftests for it at that point. > > > > I'd go for fixing the test case if possible. Mike, would it be fine if we > > go back to /dev/hugepages path based approach in the test case? > > > > No problem going back to using a file for private mapping testing. Removing > that was more of a simplification, because of new MADV_DONTNEED support. > Just want to make sure we also keep remap and remove event testing. Yeah definitely, thanks Mike! -- Peter Xu
