Hi Arnd, ---- On Mon, 11 Jul 2022 23:06:50 +0800 Arnd Bergmann <arnd@xxxxxxxx> wrote --- > On Mon, Jul 11, 2022 at 4:51 PM Li Chen <me@linux.beauty> wrote: > > ---- On Mon, 11 Jul 2022 21:36:12 +0800 Arnd Bergmann <arnd@xxxxxxxx> wrote --- > > > On Mon, Jul 11, 2022 at 2:24 PM Li Chen <me@linux.beauty> wrote: > > > > > > > +config OF_RESERVED_MEM_DIO_SUPPORT > > > > + bool "add Direct I/O support to reserved_mem" > > > > + depends on ZONE_DEVICE && ARCH_KEEP_MEMBLOCK > > > > + help > > > > + By default, reserved memory don't get struct page support, which > > > > + means you cannot do Direct I/O from this region. This config takes > > > > + uses of ZONE_DEVICE and treats rmem as hotplug mem to get struct > > > > + page and DIO support. > > > > > > This probably does not need to be user visible, it's enough to select it from > > > the drivers that need it. > > > > When you say "user visible", do you mean the config can be dropped or something else like Kconfig type other than bool? > > I mean this can be a hidden option, which you can do by leaving out the > one-line description after the 'bool' keyword. The option will still > be selectable > in Kconfig files from other options, but not shown in 'make menuconfig'. > > Arnd > Roger that. I will do it in v2. Regards, Li