Many thanks for inspecting these, and so soon. On Tue, 21 Feb 2012, KAMEZAWA Hiroyuki wrote: > > Hmm.. a nitpick. > > You do > lruvec = mem_cgroup_page_lruvec(page, zone); > > What is the difference from > > lruvec = mem_cgroup_page_lruvec(page, page_zone(page)) > > ? I hope they were equivalent: I just did it that way because in all cases the zone had already been computed, so that saved recomputing it - as I understand it, in some layouts (such as mine) it's pretty cheap to work out the page's zone, but in others an expense to be avoided. But then you discovered that it soon got removed again anyway. Hugh > > If we have a function > lruvec = mem_cgroup_page_lruvec(page) > > Do we need > lruvec = mem_cgroup_page_lruvec_zone(page, zone) > > ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>