On Wed, Jul 06, 2022 at 11:57:07AM +0200, Adam Sindelar wrote:
> mrelease_test should return KSFT_SKIP when process_mrelease is not
> defined, but due to a perror call consuming the errno, it returns
> KSFT_FAIL.
>
> This patch decides the exit codes before calling perror.
As requested on the v2 version of the patch, please also include a "Fixes" line
here (see [0]):
Fixes: 33776141b812 ("selftests: vm: add process_mrelease tests")
[0]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
>
> Signed-off-by: Adam Sindelar <adam@xxxxxxxxxxxx>
> ---
> v1->v2: Fixed second instance in the same file
> v2->v3: Fixed remaining instances of errno mishandling
>
> tools/testing/selftests/vm/mrelease_test.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/mrelease_test.c b/tools/testing/selftests/vm/mrelease_test.c
> index 96671c2f7d48..6c62966ab5db 100644
> --- a/tools/testing/selftests/vm/mrelease_test.c
> +++ b/tools/testing/selftests/vm/mrelease_test.c
[...]
Looks good otherwise, thanks.
Reviewed-by: David Vernet <void@xxxxxxxxxxxxx>
