On Mon, Jul 04, 2022 at 09:26:22AM +0300, Mike Rapoport wrote: > I'd go with PMD_ENTRY_ORDER as Russell suggested last year. > > From 6389dfb2e5ae5b040ca1c8f07a071d8da2873b13 Mon Sep 17 00:00:00 2001 > From: Mike Rapoport <rppt@xxxxxxxxxxxxx> > Date: Mon, 4 Jul 2022 09:17:40 +0300 > Subject: [PATCH] ARM: head.S: rename PMD_ORDER to PMD_ENTRY_ORDER > > PMD_ORDER denotes order of magnitude for a PMD entry, i.e PMD entry > size is 2 ^ PMD_ORDER. > > Rename PMD_ORDER to PMD_ENTRY_ORDER to allow a generic definition of > PMD_ORDER as order of a PMD allocation: (PMD_SHIFT - PAGE_SHIFT). > > Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx> Yes, absolutely. Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> I really don't buy the argument that we should not be using "order" here and we need to make up some other random idiotic term just because Linux uses "order" *elsewhere* for PAGE_SIZE * 2^n. The Linux kernel doesn't get to redefine standard terms, and certainly doesn't get to demand that one has to make up another name for a standard term because it conflicts with some other usage of that term that's non-standard. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
