On Thu 16-02-12 13:50:19, Myklebust, Trond wrote: > On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > > CC: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> > > CC: linux-nfs@xxxxxxxxxxxxxxx > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > --- > > fs/nfs/file.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/fs/nfs/file.c b/fs/nfs/file.c > > index c43a452..2407922 100644 > > --- a/fs/nfs/file.c > > +++ b/fs/nfs/file.c > > @@ -525,6 +525,9 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > > /* make sure the cache has finished storing the page */ > > nfs_fscache_wait_on_page_write(NFS_I(dentry->d_inode), page); > > > > + /* Update file times before taking page lock */ > > + file_update_time(filp); > > + > > lock_page(page); > > mapping = page->mapping; > > if (mapping != dentry->d_inode->i_mapping) > > Hi Jan, > > file_update_time() is a no-op in NFS, since we set S_NOATIME|S_NOCMTIME > on all inodes. Thanks. I've discarded the patch. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>