On Fri, Jul 01, 2022 at 04:04:21PM +0800, Baolin Wang wrote: > > Using pgtable_pud_page_ctor() and pgtable_pud_page_dtor() would be > > consistent with what we currently have for PTEs and PMDs. > > > > This applies to all the additions of pgtable_page_dec() and > > pgtable_page_inc(). > > OK. I can add pgtable_pud_page_ctor() and pgtable_pud_page_dtor() helpers to > keep consistent, which are just wrappers of pgtable_page_inc() and > pgtable_page_dec(). I think you misunderstand Mike. Don't add pgtable_page_inc() and pgtable_page_dec(). Just add pgtable_pud_page_ctor() and pgtable_pud_page_dtor(). At least, that was what I said last time yo uposted these patches.
