On Fri, Jul 01, 2022 at 06:30:30PM +0200, Adam Sindelar wrote: > The test va_128TBswitch.c expects to be able to pass mmap an address hint > and length that cross the address 1<<47. On x86_64, this is not possible > without 5-level page tables, so the test fails. > > The test is already only run on 64-bit powerpc and x86_64 archs, but this > patch adds an additional check on x86_64 that skips the test if > PG_TABLE_LEVELS < 5. There is precedent for checking /proc/config.gz in > selftests, e.g. in selftests/firmware. > > Running the tests produces the desired output: > > sudo make -C tools/testing/selftests TARGETS=vm run_tests > --------------------------- > running ./va_128TBswitch.sh > --------------------------- > ./va_128TBswitch.sh: PG_TABLE_LEVELS=4, must be >= 5 to run this test > [SKIP] > ------------------------------- > > Signed-off-by: Adam Sindelar <adam@xxxxxxxxxxxx> [...] Thanks, Adam. Looks good to me. Reviewed-by: David Vernet <void@xxxxxxxxxxxxx>
