On Tue, Jun 28, 2022 at 12:04:28AM +0000, Nadav Amit wrote: > > [1] commit 824ddc601adc ("userfaultfd: provide unmasked address on page-fault") > > Indeed this change of behavior (not aligning to huge-pages when flags is > not set) was unintentional. If you want to fix it in a separate patch so > it would be backported, that may be a good idea. The fix seems to be straightforward, though. Nadav, wanna post a patch yourself? That seems to be an accident and it's just that having sub-page mapping rely on the accident is probably not desirable.. So irrelevant of the separate patch I'd suggest we keep the requirement on enabling the exact addr feature for sub-page mapping. Thanks, -- Peter Xu