On Fri, Feb 17, 2012 at 10:15 AM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote: > On Fri, 2012-02-17 at 09:27 -0500, Kautuk Consul wrote: >> Staticize the page_referenced_anon and page_referenced_file >> functions. >> These functions are called only from page_referenced. > > Subject and changelog say: staticize, which I read to mean: make static. > Yet what the patch does is make them inline ?!? Yes, sorry my mistake. :) > > Also, if they're static and there's only a single callsite, gcc will > already inline them, does this patch really make a difference? I just sent this patch for what I thought was "correctness", but I guess we can let this be if you are absolutely sure that all GCC cross compilers for all platforms will guarantee inlining. > >> -static int page_referenced_anon(struct page *page, >> +static inline int page_referenced_anon(struct page *page, > > Please reply back if you feel I should resend this patch with modified description. Else, I'll just forget about this one. :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>