On Thu, Feb 16, 2012 at 01:53:04AM -0800, Hugh Dickins wrote: > Yes (and I think less troublesome than most BUGs, coming at exit > while not holding locks; though we could well make it a WARN_ON, > I don't think that existed back in the day). A WARN_ON would be fine with me, go ahead if you prefer it... only risk would be to go unnoticed or be underestimated. I am ok with the BUG_ON too (even if this time it triggered false positives... sigh). > Acked-by: Hugh Dickins <hughd@xxxxxxxxxx> Thanks for the quick review! > In looking into the bug, it had actually bothered me a little that you > were setting aside those pages, yet not counting them into nr_ptes; > though the only thing that cares is oom_kill.c, and the count of pages > in each hugepage can only dwarf the count in nr_ptes (whereas, without > hugepages, it's possible to populate very sparsely and nr_ptes become > significant). Agreed, it's not significant either ways. Running my two primary systems with this applied for half a day and no problem so far so it should be good for -mm at least. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>