On 2022/6/23 11:22, Kirill A. Shutemov wrote: > On Thu, Jun 23, 2022 at 01:06:18AM +0800, Miaohe Lin wrote: >> Use helper function vma_lookup to lookup the needed vma and use help macro >> IS_ERR_OR_NULL to check the validity of page to simplify the code. Minor >> readability improvement. > > Grouping of changing seems random, but okay. I group them because they belong to the same function. Should I split these two changes? Many thanks for reviewing and comment! >