Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Anshuman Khandual <anshuman.khandual@xxxxxxx>
Subject: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Jun 2022 22:55:40 -0700
Cc: kernel test robot <lkp@xxxxxxxxx>, linux-mm@xxxxxxxxx, kbuild-all@xxxxxxxxxxxx, hch@xxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <da75a2d1-afc5-b6ff-dce0-ef0b20dbfde0@arm.com>
References: <20220616040924.1022607-2-anshuman.khandual@arm.com> <202206162004.ak9KTfMD-lkp@intel.com> <da75a2d1-afc5-b6ff-dce0-ef0b20dbfde0@arm.com>

On Mon, Jun 20, 2022 at 10:15:31AM +0530, Anshuman Khandual wrote:
> +extern pgprot_t protection_map[16];


externs in .c files are never a good idea.  I'd rather add a helper
function toadd pgprot_encrypted to protection_map to pgprot.c.

References:
- [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
  - From: Anshuman Khandual
- Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
  - From: kernel test robot
- Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
  - From: Anshuman Khandual

Prev by Date: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
Next by Date: Re: [PATCH v5 01/13] mm: add zone device coherent type memory support
Previous by thread: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
Next by thread: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux