On Thu, Jun 16, 2022 at 09:42:10AM +0100, Vincenzo Frascino wrote: > On 6/10/22 16:21, Catalin Marinas wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index e008a3df0485..f6ed240870bc 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -2397,6 +2397,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order, > > bool init = !want_init_on_free() && want_init_on_alloc(gfp_flags) && > > !should_skip_init(gfp_flags); > > bool init_tags = init && (gfp_flags & __GFP_ZEROTAGS); > > + int i; > > > > Nit: Since "i" is not used outside of the for loop context we could use the > contract form "for (int i = 0; ..." which is allowed by C11. Oh yeah, Linux moved to C11 in 5.18. But it looks better to be consistent with the other for loop in this file. > Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx> Thanks. -- Catalin
