On Mon, Feb 13, 2012 at 7:13 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > From ffd1b013fe294a80c12e3f30e85386135a6fb284 Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Date: Thu, 2 Feb 2012 11:49:59 +0900 > Subject: [PATCH 3/6] memcg: remove PCG_MOVE_LOCK flag from page_cgroup. > > PCG_MOVE_LOCK is used for bit spinlock to avoid race between overwriting > pc->mem_cgroup and page statistics accounting per memcg. > This lock helps to avoid the race but the race is very rare because moving > tasks between cgroup is not a usual job. > So, it seems using 1bit per page is too costly. > > This patch changes this lock as per-memcg spinlock and removes PCG_MOVE_LOCK. > > If smaller lock is required, we'll be able to add some hashes but > I'd like to start from this. > > Changelog: > - fixed to pass memcg as an argument rather than page_cgroup. > and renamed from move_lock_page_cgroup() to move_lock_mem_cgroup() > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Seems good. Thanks. Acked-by: Greg Thelen <gthelen@xxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href