On 09.06.22 22:13, Peter Xu wrote: > On Thu, Jun 09, 2022 at 11:48:06AM -0700, Mike Kravetz wrote: >> On 6/9/22 06:24, Alejandro Colomar wrote: >>> Hi Mike, >>> >>> On 6/9/22 01:45, Mike Kravetz wrote: >>>> Clarify that madvise only works on full pages, and remove references >>>> to 'bytes'. >>>> >>>> Update MADV_DONTNEED and MADV_REMOVE sections to remove notes that >>>> HugeTLB mappings are not supported. Indicate the releases when they >>>> were first supported as well as alignment restrictions. >>>> >>>> Signed-off-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> >>>> Acked-by: Peter Xu <peterx@xxxxxxxxxx> >>> >>> Please check some comments below. >>> >>> Thanks, >>> >> >> Thank you! >> >> And, my apologies for not looking at formatting requirements. >> Will send a v4 shortly. > > Alex, > > Do you think we could add some of the semantic newline requirement into > CONTRIBUTING file explicitly? Although there's a pointer to man7 man-pages > but the semantic newlines rules seem to be easily overlooked. > > IMHO there can even be examples as you quoted in the link on "UNIX For > Beginners": > > https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man7/man-pages.7?h=alx/main&id=6ff6f43d68164f99a8c3fb66f4525d145571310c > > Maybe that'll ease both the maintainers and the contributors? Maybe something similar checkpatch in Linux/qemu could point out a lot of these possible issues and reduce Maintainer overhead. Nobody reads docs after all if not forced to ;) -- Thanks, David / dhildenb
