compound_pincount_ptr is stored at first tail page instead of second tail page now. And if it or some other field changes again in the future, data overwritten might happen. Calling prep_compound_head() outside the loop to prevent such possible issue. No functional change intended. Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> --- mm/page_alloc.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 0243a21e69b1..fc3770f28d1a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6772,17 +6772,8 @@ static void __ref memmap_init_compound(struct page *head, __init_zone_device_page(page, pfn, zone_idx, nid, pgmap); prep_compound_tail(head, pfn - head_pfn); set_page_count(page, 0); - - /* - * The first tail page stores compound_mapcount_ptr() and - * compound_order() and the second tail page stores - * compound_pincount_ptr(). Call prep_compound_head() after - * the first and second tail pages have been initialized to - * not have the data overwritten. - */ - if (pfn == head_pfn + 2) - prep_compound_head(head, order); } + prep_compound_head(head, order); } void __ref memmap_init_zone_device(struct zone *zone, -- 2.23.0
