Miaohe Lin <linmiaohe@xxxxxxxxxx> writes:
> On 2022/5/31 14:06, Ying Huang wrote:
>> On Mon, 2022-05-30 at 19:30 +0800, Miaohe Lin wrote:
>>> Commit 3268c63eded4 ("mm: fix move/migrate_pages() race on task struct")
>>> extends the period of the rcu_read_lock until after the permissions checks
>>> are done to prevent the task pointed to from changing from under us. But
>>> the task_struct refcount is also taken at that time, the reference to task
>>> is guaranteed to be stable. So it's unnecessary to extend the period of
>>> the rcu_read_lock. Release the rcu lock after task refcount is successfully
>>> grabbed to reduce the rcu holding time.
>>
>> Sorry for late reply, I am busy on something else recently.
>
> That's all right. Many thanks for your hard work. :)
>
>>
>> I have just read the whole thread of the original patch discussion.
>> During discussion, in
>>
>> https://lore.kernel.org/lkml/alpine.DEB.2.00.1202241131400.3726@xxxxxxxxxxx/
>>
>> a patch that is same as your one is proposed. Then in the following
>> message, Eric think that the rcu read lock should be released until
>> permission is checked,
>>
>> https://lore.kernel.org/lkml/87sjhzun47.fsf@xxxxxxxxxxxx/
>>
>> "
>> At the moment I suspect the permissions checks are not safe unless
>> performed under both rcu_read_lock and task_lock to ensure that
>> the task<->mm association does not change on us while we are
>> working. Even with that the cred can change under us but at least
>> we know the cred will be valid until rcu_read_unlock happens.
>> "
>>
>> So the rcu lock duration is enlarged in the following message.
>>
>> https://lore.kernel.org/lkml/alpine.DEB.2.00.1202271238450.32410@xxxxxxxxxxx/
>>
>> But, after some thought, I don't think extended rcu read lock adds much
>> value. Because after permission checking the permission may still be
>> changed. There's no much difference.
>>
>> So, I have no objection to the patch itself. But you should add more
>> information in patch description about why the RCU proected region is
>> extended and why we can reduce it.
>
> Does below patch description makes sense for you?
>
> "
> Commit 3268c63eded4 ("mm: fix move/migrate_pages() race on task struct")
> extends the period of the rcu_read_lock until after the permissions checks
> are done because it suspects the permissions checks are not safe unless
> performed under both rcu_read_lock and task_lock to ensure the task<->mm
> association does not change on us while we are working [1]. But extended
> rcu read lock does not add much value. Because after permission checking
> the permission may still be changed. There's no much difference. So it's
> unnecessary to extend the period of the rcu_read_lock. Release the rcu
> lock after task refcount is successfully grabbed to reduce the rcu holding
> time.
>
> [1] https://lore.kernel.org/lkml/87sjhzun47.fsf@xxxxxxxxxxxx/
> "
It doesn't make sense to me.
I don't see any sleeping functions called from find_mm_struct or
kernel_migrate_pages in the area kernel_migrate_pages in the area of the
code protected by get_task_struct. So at a very basic level I see a
justification for dirtying a cache line twice with get_task_struct and
put_task_struct to reduce rcu_read_lock hold times.
I would contend that a reasonable cleanup based up on the current state
of the code would be to extend the rcu_read_lock over get_task_mm so
that a reference to task_struct does not need to be taken. That has
the potential to reduce contention and reduce lock hold times.
The code is missing a big fat comment with the assertion that it is ok
if the permission checks are racy because the race is small, and the
worst case thing that happens is the page is migrated to another
numa node.
Given that the get_mm_task takes task_lock the cost of dirtying the
cache line is already being paid. Perhaps not extending task_lock hold
times a little bit is justified, but I haven't seen that case made.
This seems like code that is called little enough it would be better for
it to be correct, and not need big fat comments explaining why it
doesn't matter that they code is deliberately buggy.
In short it does not make sense to me to justify a patch for performance
reasons when it appears that extending the rcu_read_lock hold time and
not touch the task reference count would stop dirtying a cache line and
likely have more impact.
Eric
