Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Sat, May 28, 2022, 01:37 Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> wrote:
On Fri, May 27, 2022 at 12:48:09PM +0200, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter and more understandable.
> Main change is the elimination of code duplicity in the case of
> merge next check. This is done by first doing checks and caching
> the results before executing the merge itself. The variable 'area' is
> divided into 'mid' and 'res' as previously it was used for two purposes,
> as the middle VMA between prev and next and also as the result of the
> merge itself. Exit paths are also unified.
>
> Signed-off-by: Jakub Matěna <matenajakub@xxxxxxxxx>

You've ignored my ack. Or is there substantial changes that you want me to
review again?

I decided to divide the variable 'area' into two variables 'mid' and 'res'. That's the only change since your ack. You suggested renaming so I wasn't sure if that's big enough change or not to still add the ack.

Jakub Matěna 

--
 Kirill A. Shutemov 

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux