> >> > > > > I am confused by why we need to call insn_get_length(insn) before > > checking insn->rex_prefix.nbytes? Is it needed. > > Ah, certainly, no, if the insn is already decoded. Okay, > > > > uprobe->arch_info.rip_rela_target_address = 0x0; > > if (!insn_rip_relative(insn)) > > return; > > Here, I think it is better to add a comment that > insn_rip_relative() decodes until modrm. :) Will do. > > > return; > > } > > Confirmed, this looks good to me ;) > > Thanks! Okay, Thanks for confirming, Do you have a handy instruction whose REX.B is set that I could use to test. -- Thanks and Regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>