Re: [RFC PATCH v4 05/17] iomap: Add gfp parameter to iomap_page_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/22/22 12:21 AM, Christoph Hellwig wrote:
> On Fri, May 20, 2022 at 11:36:34AM -0700, Stefan Roesch wrote:
>> -	iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)),
>> -			GFP_NOFS | __GFP_NOFAIL);
>> +	iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), gfp);
> 
> Please avoid the overly long line.

Fixed.

> 
> Looking at this I also thnk my second suggestion of just passing the
> flags to iomap_page_create and let iomap_page_create itself pick the
> gfp_t might be the better option here.

Replaced the gfp paramter with a flags parameter and decide on setting
the gfp flags in iomap_page_create.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux