Re: [PATCH 02/15] mm: sl[au]b: Add knowledge of PFMEMALLOC reserve pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 8 Feb 2012, Mel Gorman wrote:

> o struct kmem_cache_cpu could be left alone even though it's a small saving

Its multiplied by the number of caches and by the number of
processors.

> o struct slab also be left alone
> o struct array_cache could be left alone although I would point out that
>   it would make no difference in size as touched is changed to a bool to
>   fit pfmemalloc in

Both of these are performance critical structures in slab.

> o It would still be necessary to do the object pointer tricks in slab.c

These trick are not done for slub. It seems that they are not necessary?

> remain. However, the downside of requiring a page flag is very high. In
> the event we increase the number of page flags - great, I'll use one but
> right now I do not think the use of page flag is justified.

On 64 bit I think there is not much of an issue with another page flag.

Also consider that the slab allocators do not make full use of the other
page flags. We could overload one of the existing flags. I removed
slubs use of them last year. PG_active could be overloaded I think.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]