On 2022/5/23 14:46, Muchun Song wrote:
On Mon, May 23, 2022 at 02:32:59PM +0800, Kefeng Wang wrote:
On 2022/5/20 18:26, Muchun Song wrote:
On Fri, May 20, 2022 at 10:18:33AM +0800, Kefeng Wang wrote:
Use PAGE_ALIGNED macro instead of IS_ALIGNED and passing PAGE_SIZE.
Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
Acked-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
Thanks,
BTW, there is a similar case in page_fixed_fake_head(), woule you like to
improve that as well?
IS_ALIGNED is defined in include/linux/align.h, but PAGE_ALIGNED is in include/linux/mm.h,
so better to keep unchanged in include/linux/page-flags.h.
Maybe we could move this macro to page-flags.h or align.h so that we could
reuse it?
align.h is inappropriate, could be page-flags.h, but this could affect
the include of 'mm.h'，so I think it is unnecessary to move the
PAGE_ALIGNED(and there is a PAGE_ALIGN too, no need to move both of them).
Thanks.
.
