Hi, Thanks for looking into this patch, Yosry Ahmed <yosryahmed@xxxxxxxxxx> writes: > On Wed, May 18, 2022 at 3:38 PM Vaibhav Jain <vaibhav@xxxxxxxxxxxxx> wrote: >> >> [1] Provides a way for user-space to trigger proactive reclaim by introducing >> a write-only memcg file 'memory.reclaim'. However reclaim stats like number >> of pages scanned and reclaimed is still not directly available to the >> user-space. >> >> This patch proposes to extend [1] to make the memcg file 'memory.reclaim' >> readable which returns the number of pages scanned / reclaimed during the >> reclaim process from 'struct vmpressure' associated with each memcg. This should >> let user-space asses how successful proactive reclaim triggered from memcg >> 'memory.reclaim' was ? > > Isn't this a racy read? struct vmpressure can be changed between the > write and read by other reclaim operations, right? Read/write of vmpr stats is always done in context of vmpr->sr_lock which is also the case for this patch. So not sure how the read is racy ?. > > I was actually planning to send a patch that does not updated > vmpressure for user-controller reclaim, similar to how PSI is handled. > Ok, not sure if I am inferring correctly as to how how that would be useful. Can you please provide some more context. The primary motivation for this patch was to expose the vmpressure stats to user space that are available with cgroup-v1 but not with cgroup-v2 AFAIK > The interface currently returns -EBUSY if the entire amount was not > reclaimed, so isn't this enough to figure out if it was successful or > not? Userspace may very well want to know the amount of memory that was partially reclaimed even though write to "memory.reclaim" returned '-EBUSY'. This feedback can be useful info for implementing a retry loop. > If not, we can store the scanned / reclaim counts of the last > memory.reclaim invocation for the sole purpose of memory.reclaim > reads. Sure sounds reasonable to me. > Maybe it is actually more intuitive to users to just read the > amount of memory read? In a format that is similar to the one written? > > i.e > echo "10M" > memory.reclaim > cat memory.reclaim > 9M > Agree, I will address that in v2. <snip> -- Cheers ~ Vaibhav
