On Mon, May 09, 2022 at 09:14:07PM +0800, Miaohe Lin wrote:
> refill_swap_slots_cache is always called when cache->nr is 0. And if
> cache->nr != 0, we should return cache->nr instead of 0. So remove
> such buggy and confusing check.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
With Andrew's ammendment:
Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>
> ---
> mm/swap_slots.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap_slots.c b/mm/swap_slots.c
> index 2f877e6f87d7..2a65a89b5b4d 100644
> --- a/mm/swap_slots.c
> +++ b/mm/swap_slots.c
> @@ -258,7 +258,7 @@ void enable_swap_slots_cache(void)
> /* called with swap slot cache's alloc lock held */
> static int refill_swap_slots_cache(struct swap_slots_cache *cache)
> {
> - if (!use_swap_slot_cache || cache->nr)
> + if (!use_swap_slot_cache)
> return 0;
>
> cache->cur = 0;
> --
> 2.23.0
>
>
--
Oscar Salvador
SUSE Labs
