Re: [PATCH] compact_pgdat: workaround lockdep warning in kswapd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 6 Feb 2012, Andrew Morton wrote:
> On Mon, 6 Feb 2012 11:40:08 -0800 (PST)
> Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> 
> > I get this lockdep warning from swapping load on linux-next
> > (20120201 but I expect the same from more recent days):
> 
> The patch looks good as a standalone optimisation/cleanup.  The lack of
> clarity on the lockdep thing is a concern - I have a feeling we'll be
> bitten again.

lockdep's delphic mutterings generally strain my brain; but it has an
embarrassing habit of proving right after you think it's plain wrong.

> 
> This fix seems to be applicable to mainline?

No, that call from kswapd to compact_pgdat() comes from a recent
mmotm patch by Rik, "vmscan: kswapd carefully call compaction"
(but I suspect my patch doesn't fit in immediately after that,
I think there were maybe more changes in between).

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]