Re: [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miaohe Lin <linmiaohe@xxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Thu, 12 May 2022 15:37:55 +0200
Cc: willy@xxxxxxxxxxxxx, vbabka@xxxxxxx, dhowells@xxxxxxxxxx, neilb@xxxxxxx, apopple@xxxxxxxxxx, surenb@xxxxxxxxxx, peterx@xxxxxxxxxx, naoya.horiguchi@xxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20220509131416.17553-8-linmiaohe@huawei.com>
Organization: Red Hat
References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-8-linmiaohe@huawei.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 09.05.22 15:14, Miaohe Lin wrote:
> If p is NULL, __swap_duplicate will already return -EINVAL. So if we
> reach here, p must be non-NULL.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>


-- 
Thanks,

David / dhildenb

References:
- [PATCH 00/15] A few cleanup patches for swap
  - From: Miaohe Lin
- [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate
  - From: Miaohe Lin

Prev by Date: Re: [PATCH 06/15] mm/swap: remove buggy cache->nr check in refill_swap_slots_cache
Next by Date: Re: [PATCH 08/15] mm/swap: make page_swapcount and __lru_add_drain_all
Previous by thread: [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate
Next by thread: Re: [PATCH 07/15] mm/swap: remove unneeded p != NULL check in __swap_duplicate
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux