On 5/4/22 11:28, Matthew Wilcox (Oracle) wrote: > Shrinks shmem_add_to_page_cache() by 16 bytes. All the callers grow, > but this is temporary as they will all be converted to folios soon. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > --- > mm/shmem.c | 57 +++++++++++++++++++++++++++++------------------------- > 1 file changed, 31 insertions(+), 26 deletions(-) Hi Matthew, Was building next-20220510 without CONFIG_TRANSPARENT_HUGEPAGE set and saw this BUILD_BUG. Looks like it might be related to this patch/series. ./include/linux/vm_event_item.h:148:30: note: in expansion of macro ‘BUILD_BUG’ 148 | #define THP_FILE_FALLBACK ({ BUILD_BUG(); 0; }) | ^~~~~~~~~ mm/shmem.c:721:48: note: in expansion of macro ‘THP_FILE_FALLBACK’ 721 | count_vm_event(THP_FILE_FALLBACK); | ^~~~~~~~~~~~~~~~~ -- Mike Kravetz