2012/2/3 Michal Nazarewicz <mina86@xxxxxxxxxx>: >>> +static inline bool migrate_async_suitable(int migratetype) > > On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton <dhillf@xxxxxxxxx> wrote: >> >> Just nitpick, since the helper is not directly related to what async >> means, >> how about migrate_suitable(int migrate_type) ? > > > I feel current name is better suited since it says that it's OK to scan this > block if it's an asynchronous compaction run. > The input is the migrate type of page considered, and the async is only one of the modes that compaction should be carried out. Plus the helper is also used in other cases where async is entirely not concerned. That said, the naming is not clear, if not misleading. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>