On Mon, 9 May 2022 08:32:32 -0400 Tom Rix <trix@xxxxxxxxxx> wrote:
> The clang build fails with
> mm/shmem.c:2337:8: error: variable 'page' is uninitialized when used here [-Werror,-Wuninitialized]
> if (!page)
> ^~~~
>
> In the commit listed in the fixes, there was a change to the
> from
> page = shmem_alloc_page(..);
> to
> page = &shmem_alloc_folio(..)->page;
> But in this case, instead of replacing, the setting of page was
> deleted. So restore page with its new api.
>
> ...
>
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -2334,6 +2334,7 @@ int shmem_mfill_atomic_pte(struct mm_struct *dst_mm,
>
> if (!*pagep) {
> ret = -ENOMEM;
> + page = &shmem_alloc_folio(gfp, info, pgoff)->page;
> if (!page)
> goto out_unacct_blocks;
>
Thanks, this is fixed in v2 of Matthew's "Folio patches for 5.19"
series.
I've just now pushed all that out to kernel.org so next linux-next
should be a happier place.
