Re: [PATCH] mm/shmem: initialize folio to NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/9/22 6:59 AM, Matthew Wilcox wrote:
On Mon, May 09, 2022 at 08:31:16AM -0400, Tom Rix wrote:
The clang build fails with
mm/shmem.c:1704:7: error: variable 'folio' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
   if (!page) {
        ^~~~~
The error handler for !page jumps to an if-check for an unset folio.
So initialize folio to NULL.
I appreciate you're trying to help, but the fourth report of a problem
adds more noise than utility.

https://lore.kernel.org/linux-mm/?q=shmem+folio

shows emails about this from the cgelbot, Dan Carpenter, SeongJae Park,
Colin King, Nathan Chancellor and Sebastian Siewior.  So actually you
were seventh, not fourth.

From my point of view, the build has been broken for a week.

It would be good if this and the other folio issue was fixed in linux-next soon.

Tom







[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux