On Fri, Feb 3, 2012 at 11:53 PM, Michal Hocko <mhocko@xxxxxxx> wrote:
On Fri 03-02-12 14:39:50, Johannes Weiner wrote:Hmm, I thought we already sorted this out https://lkml.org/lkml/2012/1/26/25 ?
> Michal, this keeps coming up, please decide between the proposed
> solutions ;-)
I don't know previous history about this variable.
Is it same? Please, adjust this patch or fix the unsuitable
variable 'do_numainfo' as I mentioned.
-->
> On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote:
> > Actually, Usage of the variable 'do_numainfo'is not suitable for gcc compiler.
> > Declare the variable 'do_numainfo' if the number of NUMA nodes > 1.
> >
> > Signed-off-by: Geunsik Lim <geunsik.lim@xxxxxxxxxxx>
> > ---
> > mm/memcontrol.c | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 556859f..4e17ac5 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page)
> > /* threshold event is triggered in finer grain than soft limit */
> > if (unlikely(mem_cgroup_event_ratelimit(memcg,
> > MEM_CGROUP_TARGET_THRESH))) {
> > - bool do_softlimit, do_numainfo;
> > + bool do_softlimit;
> > +#if MAX_NUMNODES > 1
> > + bool do_numainfo;
> > +#endif
> >
> > do_softlimit = mem_cgroup_event_ratelimit(memcg,
> > MEM_CGROUP_TARGET_SOFTLIMIT);
> > --
> > 1.7.8.1
> >
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
----
Best regards,
Geunsik Lim, Samsung Electronics
----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/