On Fri, Feb 03, 2012 at 09:08:34AM -0500, Christoph Hellwig wrote: > On Fri, Feb 03, 2012 at 09:38:23PM +0800, Wu Fengguang wrote: > > On Fri, Feb 03, 2012 at 06:57:06PM +0530, Amit Sahrawat wrote: > > > This will cover all the invocations for writepages to be called with > > > plugging support. > > > > Thanks. I'll test it on the major filesystems. But would you > > name a few filesystems that are expected to benefit from it? > > It's not obvious because some FS ->writepages eventually calls > > generic_writepages() which already does plugging. > > Ant that's exactly where it should stay instead of beeing sprinkled all > over the VM code. > > NAK to the patch. We've actually had problems with plugging in the higher layers. writepages is queueing up lots and lots and lots of pages for IO, and especially on SSDs we want these IOs sent sooner rather than later. I'm not sure yet how to make the plugs aware of the please-feed-me-right-away demands of lower storage, but I'd rather not add more high level plugs that the filesystems can't control. -chris -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>