Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Minchan-Kim/mm-fix-is_pinnable_page-against-on-cma-page/20220503-013733 base: https://github.com/hnaz/linux-mm master config: nios2-defconfig (https://download.01.org/0day-ci/archive/20220503/202205030306.in794Jr3-lkp@xxxxxxxxx/config) compiler: nios2-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1b8636710c31d44310f1d344e337c207562b851d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Minchan-Kim/mm-fix-is_pinnable_page-against-on-cma-page/20220503-013733 git checkout 1b8636710c31d44310f1d344e337c207562b851d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=nios2 prepare If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/pid_namespace.h:7, from include/linux/ptrace.h:10, from arch/nios2/kernel/asm-offsets.c:9: include/linux/mm.h: In function 'is_pinnable_page': >> include/linux/mm.h:1630:54: error: 'MIGRATE_CMA' undeclared (first use in this function); did you mean 'MIGRATE_SYNC'? 1630 | return !(is_zone_movable_page(page) || mt == MIGRATE_CMA || | ^~~~~~~~~~~ | MIGRATE_SYNC include/linux/mm.h:1630:54: note: each undeclared identifier is reported only once for each function it appears in >> include/linux/mm.h:1631:23: error: 'MIGRATE_ISOLATE' undeclared (first use in this function); did you mean 'MIGRATE_MOVABLE'? 1631 | mt == MIGRATE_ISOLATE || is_zero_pfn(page_to_pfn(page))); | ^~~~~~~~~~~~~~~ | MIGRATE_MOVABLE make[2]: *** [scripts/Makefile.build:122: arch/nios2/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1283: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:226: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +1630 include/linux/mm.h 1623 1624 /* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */ 1625 #ifdef CONFIG_MIGRATION 1626 static inline bool is_pinnable_page(struct page *page) 1627 { 1628 int mt = get_pageblock_migratetype(page); 1629 > 1630 return !(is_zone_movable_page(page) || mt == MIGRATE_CMA || > 1631 mt == MIGRATE_ISOLATE || is_zero_pfn(page_to_pfn(page))); 1632 } 1633 #else 1634 static inline bool is_pinnable_page(struct page *page) 1635 { 1636 return true; 1637 } 1638 #endif 1639 -- 0-DAY CI Kernel Test Service https://01.org/lkp
