On Wed, Apr 27, 2022 at 2:10 PM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Tue, Apr 26, 2022 at 07:44:06AM -0700, Zach O'Keefe wrote: > > The following functions/tracepoints are shared between khugepaged and > > madvise collapse contexts. Remove the khugepaged prefixes. > > > > tracepoint:mm_khugepaged_scan_pmd -> tracepoint:mm_scan_pmd > > khugepaged_test_exit() -> test_exit() > > khugepaged_scan_abort() -> scan_abort() > > khugepaged_scan_pmd() -> scan_pmd() > > khugepaged_find_target_node() -> find_target_node() > > The khugepaged prefix can indeed be confusing, but are the new names just > too short? IMHO it'll be nice to still have some generic prefix. > > Perhaps something like "hpage_collapse_"/"hpage_"/"hpc_"/..? > If we want to keep a prefix, I'd throw my hat in with "hpage_collapse_". I feel like "collapse" should be in there, and "collapse_" on its own seems odd to me. Updated. Thanks Peter. > -- > Peter Xu >