On Thu, Apr 21, 2022 at 11:44:23PM +0000, Yosry Ahmed wrote:
> From: Shakeel Butt <shakeelb@xxxxxxxxxx>
[...]
>
> [yosryahmed@xxxxxxxxxx: refreshed to current master, updated commit
> message based on recent discussions and use cases]
> Signed-off-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
> Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
You should add "Co-developed-by" tag for yourself here.
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> Acked-by: Wei Xu <weixugc@xxxxxxxxxx>
> Acked-by: Roman Gushchin <roman.gushchin@xxxxxxxxx>
> ---
>
[...]
> +static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf,
> + size_t nbytes, loff_t off)
> +{
> + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of));
> + unsigned int nr_retries = MAX_RECLAIM_RETRIES;
> + unsigned long nr_to_reclaim, nr_reclaimed = 0;
> + int err;
> +
> + buf = strstrip(buf);
> + err = page_counter_memparse(buf, "", &nr_to_reclaim);
> + if (err)
> + return err;
> +
> + while (nr_reclaimed < nr_to_reclaim) {
> + unsigned long reclaimed;
> +
> + if (signal_pending(current))
> + return -EINTR;
> +
> + /* This is the final attempt, drain percpu lru caches in the
Fix the comment format. "/*" should be on its own line.
> + * hope of introducing more evictable pages for
> + * try_to_free_mem_cgroup_pages().
> + */
No need to send a new version if Andrew can fix these in the mm tree.
