|
Hi Arnd
Thanks for forwarding this patch.
As far as i know, we don't need CONFIG_BINFMT_SHARED_FLAT flag.
Tested on stm32f769-disco board
You can add my :
Tested-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
Thanks
Patrice
De : Arnd Bergmann <arnd@xxxxxxxx>
Envoyé : jeudi 21 avril 2022 09:12 À : Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Cc : Greg Ungerer <gerg@xxxxxxxxxxxxxx>; Eric W. Biederman <ebiederm@xxxxxxxxxxxx>; Kees Cook <keescook@xxxxxxxxxxxx>; Niklas Cassel <Niklas.Cassel@xxxxxxx>; Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>; Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>; Paul Walmsley <paul.walmsley@xxxxxxxxxx>; Palmer Dabbelt <palmer@xxxxxxxxxxx>; Albert Ou <aou@xxxxxxxxxxxxxxxxx>; Mike Frysinger <vapier@xxxxxxxxxx>; stable@xxxxxxxxxxxxxxx <stable@xxxxxxxxxxxxxxx>; linux-fsdevel@xxxxxxxxxxxxxxx <linux-fsdevel@xxxxxxxxxxxxxxx>; linux-mm@xxxxxxxxx <linux-mm@xxxxxxxxx>; linux-riscv@xxxxxxxxxxxxxxxxxxx <linux-riscv@xxxxxxxxxxxxxxxxxxx>; Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>; linux-m68k <linux-m68k@xxxxxxxxxxxxxxxxxxxx>; Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; Linux-sh list <linux-sh@xxxxxxxxxxxxxxx>; Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>; Rich Felker <dalias@xxxxxxxx>; Sudeep Holla <sudeep.holla@xxxxxxx>; Vladimir Murzin <vladimir.murzin@xxxxxxx>; Jesse Taube <Mr.Bossman075@xxxxxxxxx>; Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx>; Patrice CHOTARD <patrice.chotard@xxxxxx>; Pierre Yves MORDRET <pierre-yves.mordret@xxxxxx>; Alexandre TORGUE <alexandre.torgue@xxxxxx> Objet : Re: [PATCH] binfmt_flat: Remove shared library support On Thu, Apr 21, 2022 at 8:52 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Apr 21, 2022 at 1:53 AM Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote: > > On 21/4/22 00:58, Eric W. Biederman wrote: > > > In a recent discussion[1] it was reported that the binfmt_flat library > > > support was only ever used on m68k and even on m68k has not been used > > > in a very long time. > > > > > > The structure of binfmt_flat is different from all of the other binfmt > > > implementations becasue of this shared library support and it made > > > life and code review more effort when I refactored the code in fs/exec.c. > > > > > > Since in practice the code is dead remove the binfmt_flat shared libarary > > > support and make maintenance of the code easier. > > > > > > [1] https://lkml.kernel.org/r/81788b56-5b15-7308-38c7-c7f2502c4e15@xxxxxxxxxxxxxx > > > Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> > > > --- > > > > > > Can the binfmt_flat folks please verify that the shared library support > > > really isn't used? > > > > I can definitely confirm I don't use it on m68k. And I don't know of > > anyone that has used it in many years. > > > > > > > Was binfmt_flat being enabled on arm and sh the mistake it looks like? > > I think the question was intended to be > > Was *binfmt_flat_shared_flat* being enabled on arm and sh the > mistake it looks like? > > > > > > > arch/arm/configs/lpc18xx_defconfig | 1 - > > > arch/arm/configs/mps2_defconfig | 1 - > > > arch/arm/configs/stm32_defconfig | 1 - > > > arch/arm/configs/vf610m4_defconfig | 1 - Adding stm32, mps2 and imxrt maintainers to Cc, they are the most active armv7-m users and should know if the shared library support is used anywhere. Arnd
ST Restricted |
