On Fri, Apr 22, 2022 at 03:21:24AM +0300, Kirill A. Shutemov wrote:
> There's still #include <linux/efi.h> in misc.h. You removed one, but
> there's a second one for some reason.
I don't know which tree you're looking at but latest tip/master has:
$ git grep -E "efi\.h" arch/x86/boot/
arch/x86/boot/compressed/acpi.c:6:#include "efi.h"
arch/x86/boot/compressed/kaslr.c:25:#include "efi.h"
arch/x86/boot/compressed/misc.h:40:#include "efi.h"
arch/x86/boot/compressed/pgtable_64.c:7:#include "efi.h"
> Any plans for <linux/acpi.h>? It includes <linux/bitmap.h>:
So if misc.h is including linux/bitmap.h indirectly, you can simply
include misc.h right?
And then you'll slide under the closing door, as you say below. :)
> I also underesitmated what is required to be copied because of the
> indirect include. The list was only to compile bitmap.c. mem.c (former
> unaccepted_memory.c) would require more.
More like?
Maybe I can help out converting some of the stuff. You could push your
current state somewhere - even if it doesn't build - so that I can take
a look...
> BTW, do we have a white list of linux/ includes that allowed? minmax.h?
> math.h? What is the line.
Well, that's the thing. Even if those look innocuous now, if they get
new includes added to them, that has an influence on the decompressor.
So I'm thinking copying the required bits would be the proper way
forward.
> Maybe allow what is included directly or indirectly now? (Yes, it is my
> poor attempt to slide under closing door.)
That's basically saying, can I get this done so that I can mark my
checkbox that my task is done - you can deal with the crap later
yourself.
How about we take our time and solve this properly instead of hurrying
constantly?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
