On 4/21/22 09:02, Pasha Tatashin wrote: > On Wed, Apr 20, 2022 at 11:23 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: >> >> On Wed, Apr 20, 2022 at 12:54:08PM -0400, Pasha Tatashin wrote: >>> The rest of EXPORTs were added to be symmetric, and allow other >>> drivers to use set_*p**()/clear_p** calls. >> >> EXPORT_SYMBOLs actually have a real cost. We don't add them "for >> symmetry". > > Sure, the rest of exports can be removed, but: > >> -EXPORT_SYMBOL(__page_table_check_pte_set); > > must stay because of > > ERROR: modpost: "__page_table_check_pte_set" > [drivers/gpu/drm/i915/i915.ko] undefined! Sure, will resend.