On Tue, Apr 12, 2022 at 11:02:54AM +0100, Catalin Marinas wrote: > On Tue, Apr 12, 2022 at 05:40:58PM +0800, Herbert Xu wrote: > > I think if CRYPTO_MINALIGN makes those drivers work then so > > should cra_alignmask. And that would be a relatively easy > > patch to do. > > Yes, the patch would be simple, subject to figuring out which drivers > and what alignment they actually need (any help appreciated). > > There are already arm64 vendor kernels that change ARCH_DMA_MINALIGN to > 64, hence ARCH_KMALLOC_MINALIGN and CRYPTO_MINALIGN become 64. We also > discussed a Kconfig option for this in the past. Would that have broken > any crypto drivers that rely on a strict 128 byte alignment? Actually, I think with a cra_alignmask of 127 (the arm64 CRYPTO_MINALIGN-1), crypto_check_alg() will fail since MAX_ALGAPI_ALIGNMASK is 63. -- Catalin
